Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native filters] out-of-scope time range filters are triggered multiple times #15288

Closed
3 tasks done
graceguo-supercat opened this issue Jun 21, 2021 · 1 comment · Fixed by #15295
Closed
3 tasks done
Assignees
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard

Comments

@graceguo-supercat
Copy link

Screenshots

AJT3vCl1mS

How to reproduce the bug

  1. enable dashboard native filter
  2. add a few tabs, add a time-series chart in the 2nd tab.
  3. add time-range filter component and apply it to 2nd tab only.
  4. open dashboard, it shows first tab. but check browser console, you will see time-range filter send out a few /api/v1/time_range/?q= requests.

Expected behavior

  1. out-of-scope time-range filter should not be triggered
  2. even in the scope, time-range filter should not send multiple requests (i observed that time-range filter right now always trigger multiple requests)

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

cc @junlincc @villebro

@graceguo-supercat graceguo-supercat added #bug Bug report dashboard:native-filters Related to the native filters of the Dashboard labels Jun 21, 2021
@villebro
Copy link
Member

@graceguo-supercat I can look into this. In the meantime, these are fairly low cost requests that are mainly validating the time range, so I don't think they pose a major performance bottleneck for dashboards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants