Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): improve time range filter performance #15295

Merged
merged 5 commits into from Jun 22, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Jun 22, 2021

SUMMARY

Various improvements to time picker and time range filter:

  • Defer rendering of time range filter to first visibility like other filters. This extra logic is required since the time range filter doesn't have a regular query like other filters.
  • Make "Clear all" work again.
  • Avoid debounced time range evaluation request if the time range is unchanged. Will remove the double request on first render and also avoid re-requesting if the time range is changed back to its original value during debounce. Improvements affect native time range filter, Explore view and Filter Box where time picker is used.

AFTER

timerange-after.mp4

BEFORE

timerange-before.mp4

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@villebro villebro changed the title Villebro/fix timerange fix(native-filters): improve time range filter performance Jun 22, 2021
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! LGTM.

@villebro villebro merged commit cef3dc0 into apache:master Jun 22, 2021
@villebro villebro deleted the villebro/fix-timerange branch June 22, 2021 11:38
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
)

* fix time range default value

* defer time filter rendering to inView event

* avoid double fetching of time ranges

* lint

* move set to resolved promise
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
)

* fix time range default value

* defer time filter rendering to inView event

* avoid double fetching of time ranges

* lint

* move set to resolved promise
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
)

* fix time range default value

* defer time filter rendering to inView event

* avoid double fetching of time ranges

* lint

* move set to resolved promise
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native filters] out-of-scope time range filters are triggered multiple times
4 participants