Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Native Filter] Options for value filter should refresh when dashboard refresh but currently only when page refresh #15808

Closed
rosemarie-chiu opened this issue Jul 21, 2021 · 1 comment · Fixed by #15890
Assignees
Labels
#bug Bug report P1 Priority item - Major preset:QA Preset QA team

Comments

@rosemarie-chiu
Copy link
Contributor

rosemarie-chiu commented Jul 21, 2021

I found that when my charts are refreshed with newest data, value filter is still not refresh with the latest data.
Filter option only refreshed when I refresh the page entirely, not when dashboard is refreshed.

Expected results

On dashboard refresh, native filter should also refresh.

Actual results

Native filter only refresh on "page refresh"

Screenshots

CleanShot.2021-07-20.at.18.23.23.mp4

How to reproduce the bug

Using my example to describe here:

  1. I have a big number charts showing total of 176 feature tags, observe that value filter showing 177 (also counted NULL)
  2. I removed one of the feature tag viz:explore:gallery from my data
  3. Click refresh dashboard, observe that my chart is updated to 175 now
  4. Observe that on native filter, the number of options is not updated, and I can still find viz:explore:gallery as an option
  5. Refresh the entire page, observe that only after page refresh, value filter options refresh.

Environment

Latest master tested locally

@rosemarie-chiu rosemarie-chiu added the #bug Bug report label Jul 21, 2021
@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Jul 21, 2021
@rosemarie-chiu rosemarie-chiu changed the title [Native Filter] Options for value filter should refresh when dashboard refresh but only when page refresh [Native Filter] Options for value filter should refresh when dashboard refresh but currently only when page refresh Jul 21, 2021
@junlincc
Copy link
Member

@rosemarie-chiu thank you for filing this issue! definitely a case that we missed.
@geido 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report P1 Priority item - Major preset:QA Preset QA team
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants