Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Refresh Native Filters when Dashboard refreshes #15890

Merged
merged 5 commits into from Jul 26, 2021
Merged

fix(dashboard): Refresh Native Filters when Dashboard refreshes #15890

merged 5 commits into from Jul 26, 2021

Conversation

geido
Copy link
Member

@geido geido commented Jul 25, 2021

SUMMARY

This PR implements a onRefresh action to let the native filters reload when the dashboard reloads.

Fixes #15808

BEFORE

126416469-24a7a2ad-3f6b-4da9-9dfd-68d724a1e1eb.mp4

AFTER

untitled.dashb.3.mp4

TESTING INSTRUCTIONS

  1. Open a dashboard with Native Filters ON
  2. Add a filter
  3. Remove any of the options from the dataset
  4. Refresh the dashboard
  5. Observe that the option is not appearing in the filter

ADDITIONAL INFORMATION

@geido
Copy link
Member Author

geido commented Jul 25, 2021

@geido geido requested a review from rusackas July 25, 2021 21:41
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #15890 (96a7122) into master (9c81599) will decrease coverage by 0.02%.
The diff coverage is 41.37%.

❗ Current head 96a7122 differs from pull request most recent head 7e0664b. Consider uploading reports for the commit 7e0664b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15890      +/-   ##
==========================================
- Coverage   77.08%   77.06%   -0.03%     
==========================================
  Files         984      984              
  Lines       51788    51812      +24     
  Branches     7037     7042       +5     
==========================================
+ Hits        39923    39930       +7     
- Misses      11640    11657      +17     
  Partials      225      225              
Flag Coverage Δ
javascript 71.69% <41.37%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js 1.70% <ø> (ø)
...ntend/src/dashboard/containers/DashboardHeader.jsx 100.00% <ø> (ø)
...-frontend/src/dashboard/reducers/dashboardState.js 66.66% <0.00%> (-4.31%) ⬇️
...t-frontend/src/dashboard/actions/dashboardState.js 27.86% <18.75%> (-0.88%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 66.42% <100.00%> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx 68.22% <100.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c81599...7e0664b. Read the comment docs.

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Jul 26, 2021
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, product sign-off! thanks for the fix!!

@junlincc junlincc added the need:merge The PR is ready to be merged label Jul 26, 2021
@rusackas rusackas merged commit 1297fd9 into apache:master Jul 26, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
…he#15890)

* Implement onRefresh action

* Update tests

* Clean up

* Fix type

* Add effect dependency
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
…he#15890)

* Implement onRefresh action

* Update tests

* Clean up

* Fix type

* Add effect dependency
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
…he#15890)

* Implement onRefresh action

* Update tests

* Clean up

* Fix type

* Add effect dependency
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
…he#15890)

* Implement onRefresh action

* Update tests

* Clean up

* Fix type

* Add effect dependency
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard need:merge The PR is ready to be merged size/M v1.3 🚢 1.3.0
Projects
No open projects
6 participants