Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard][color theme] chart color are changed when refreshing dashboard #16970

Closed
2 of 3 tasks
jinghua-qa opened this issue Oct 4, 2021 · 11 comments · Fixed by #17089 or #27439
Closed
2 of 3 tasks

[dashboard][color theme] chart color are changed when refreshing dashboard #16970

jinghua-qa opened this issue Oct 4, 2021 · 11 comments · Fixed by #17089 or #27439
Assignees
Labels
#bug Bug report dashboard:colors Related to the color scheme of the Dashboard preset:QA Preset QA team

Comments

@jinghua-qa
Copy link
Member

jinghua-qa commented Oct 4, 2021

chart color are changed when refreshing dashboard

How to reproduce the bug

  1. Go to dashboard with multiple charts
  2. Applied color theme to dashboard, for example supers color
  3. Refresh dashboard
  4. Observe color of each chart
  5. See error

Expected results

Refresh dashboard did not change color of chart

Actual results

Refresh dashboard did not change color of chart

Screenshots

color.change.when.refreshing.mov

Environment

(please complete the following information):

  • browser type and version: Chrome
  • superset version: master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@jinghua-qa jinghua-qa added the #bug Bug report label Oct 4, 2021
@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Oct 4, 2021
@junlincc
Copy link
Member

junlincc commented Oct 5, 2021

@geido Let's create a new project in Projects, and manage color consistency ticket in one place https://github.com/apache/superset/projects/37

@junlincc junlincc added the dashboard:colors Related to the color scheme of the Dashboard label Oct 5, 2021
@geido geido added this to Issue in Color consistency Oct 5, 2021
@amitmiran137
Copy link
Member

confirming this issue as well in 1.3.1 version
we are working towards 1.3.2 with a few relevant fixes,
@junlincc @geido can this be prioritized ?
this is a critical bug for client-facing dashboards

@geido
Copy link
Member

geido commented Oct 7, 2021

Hello @amitmiran137 I can move this to the top of my list. No problem

@amitmiran137
Copy link
Member

@geido thanks friend ✌️

@geido geido moved this from Issue to In progress in Color consistency Oct 12, 2021
@geido geido moved this from In progress to In review in Color consistency Oct 13, 2021
@geido geido moved this from In review to Merged in Color consistency Nov 4, 2021
@D3nn3
Copy link

D3nn3 commented Dec 13, 2023

For us this happens again after migrating from 2.0.1 to 3.0.2. Can anyone else confirm?

@geido
Copy link
Member

geido commented Dec 21, 2023

For us this happens again after migrating from 2.0.1 to 3.0.2. Can anyone else confirm?

Thanks for the heads up. We are investigating the issue. Please try to disable AVOID_COLORS_COLLISION and see if that fixes it

@D3nn3
Copy link

D3nn3 commented Dec 21, 2023

Thanks for the reply @geido . I did test it and it seemed to have helped int that regard but this introduced a new issue: two different labels in the same chart could have the same color (which imho is even worse).

Seems to me like one has to decide with v3 between one of the two:

  • changing colors of labels when refreshing a dashboard page
  • or the possibility of two labels in one chart having the same color

I don't know how others handle it currently on their production environment but for us this is fairly annoying and we couldn't find any solution to it. I'm surprised that only few other people are reporting this issue

@shubham19may
Copy link

Happening with us also. @geido in SS 3.0.x

@zakaryanla
Copy link

zakaryanla commented Jan 18, 2024

Actual for 3.0.3.
disable AVOID_COLORS_COLLISION helped

@progressive-scaler
Copy link

progressive-scaler commented Mar 27, 2024

Actual for 3.1.0
I will test disabling AVOID_COLORS_COLLISION to see if its a valid workaround, or if the @D3nn3 collateral issue happens

Disabling AVOID_COLORS_COLLISION on the config file did not help :( so the problem still persists

@geido
Copy link
Member

geido commented Apr 16, 2024

Thanks everyone for reporting these issues. Working on a longer term solution here #27439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report dashboard:colors Related to the color scheme of the Dashboard preset:QA Preset QA team
Projects
8 participants