-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Color consistency #17089
fix: Color consistency #17089
Conversation
…issue_11677_save_label_colors
…issue_11677_save_label_colors
Codecov Report
@@ Coverage Diff @@
## master #17089 +/- ##
==========================================
- Coverage 77.10% 77.06% -0.04%
==========================================
Files 1037 1037
Lines 55659 55659
Branches 7612 7612
==========================================
- Hits 42914 42894 -20
- Misses 12495 12510 +15
- Partials 250 255 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…color_consistency
…color_consistency
/testenv up |
@geido Ephemeral environment spinning up at http://34.216.121.119:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
🏷️ 2021.44 |
* Update label colors on the fly * Clean up * Improve getFormDataWithExtraFilters * Improve code structure * Remove labelColors from formData * Exclude label_colors from URL * Refactor color scheme implementation * Clean up * Refactor and simplify * Fix lint * Remove unnecessary ColorMapControl * Lint * Give json color scheme precedence * Add label_colors prop in metadata * Separate owners and dashboard meta requests * Remove label_colors control * bump superset-ui 0.18.19 * Fix end of file * Update tests * Fix lint * Update Cypress * Update setColorScheme method * Use Antd modal body (cherry picked from commit 59a6502)
* Update label colors on the fly * Clean up * Improve getFormDataWithExtraFilters * Improve code structure * Remove labelColors from formData * Exclude label_colors from URL * Refactor color scheme implementation * Clean up * Refactor and simplify * Fix lint * Remove unnecessary ColorMapControl * Lint * Give json color scheme precedence * Add label_colors prop in metadata * Separate owners and dashboard meta requests * Remove label_colors control * bump superset-ui 0.18.19 * Fix end of file * Update tests * Fix lint * Update Cypress * Update setColorScheme method * Use Antd modal body
* Update label colors on the fly * Clean up * Improve getFormDataWithExtraFilters * Improve code structure * Remove labelColors from formData * Exclude label_colors from URL * Refactor color scheme implementation * Clean up * Refactor and simplify * Fix lint * Remove unnecessary ColorMapControl * Lint * Give json color scheme precedence * Add label_colors prop in metadata * Separate owners and dashboard meta requests * Remove label_colors control * bump superset-ui 0.18.19 * Fix end of file * Update tests * Fix lint * Update Cypress * Update setColorScheme method * Use Antd modal body
SUMMARY
This PR refactors the color scheme implementation and fixes the following issues:
Fixes: #11677
Fixes: #16970
Fixes: #16891
Fixes: #16961
Fixes: #16980
Fixes: #16979
It adds the ability to port custom label colors from the Dashboard to Explore.
It makes the custom label colors persistent and independent from the color scheme change in Dashboard.
KNOWN ISSUES
There are several known issues related to the color consistency project currently affecting master which will be tackled in separate PRs, as follows:
REQUIRED SUPERSET-UI PR
This PR requires the change in the related Superset-ui PR to be merged in first apache-superset/superset-ui#1406
AFTER
Change a color scheme in Explore. Then refresh.
1.explore_change_and_reload.mp4
The chart should use the colors in order and restart from the first color in the scheme when running out of available colors.
2.explore_more_series_than_colors.mp4
Chart should inherit the color scheme of the dashboard
3.dashboard_chart_inherits_color.mp4
Charts in the dashboard should use custom label color, show the change immediately, on save and on refresh
5.dashboard_custom_label.mp4
Explore should use the same color scheme and custom label colors of the originating dashboard
6.explore_inherits_dashboard_custom_labels.mp4
TESTING INSTRUCTIONS
Please follow each test case as shown in the videos above
ADDITIONAL INFORMATION