Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[color theme][chart] When #series is larger than #color, the color start from random order to repeat #16980

Closed
2 of 3 tasks
jinghua-qa opened this issue Oct 5, 2021 · 0 comments · Fixed by #17089
Closed
2 of 3 tasks
Assignees
Labels
#bug Bug report dashboard:colors Related to the color scheme of the Dashboard explore:colors Related to the color scheme in Explore preset:QA Preset QA team

Comments

@jinghua-qa
Copy link
Member

When number of series is larger than number of color, the color start from random order to repeat

How to reproduce the bug

Use clean_sales_data

  1. Go to explore, create mixed time series chart
  2. Select 'month' in group by
  3. Select a color theme of 10 (for example d3 category 10)
  4. See error

Expected results

When #series > #color, the series start from 1st color then repeat 1st color

Actual results

When #series > #color, the series start from random order then repeat 1st color

Screenshots

mixed_time_series_superset

Environment

(please complete the following information):

  • browser type and version: chrome
  • superset version: master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@jinghua-qa jinghua-qa added the #bug Bug report label Oct 5, 2021
@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Oct 5, 2021
@junlincc junlincc added this to Issue in Color consistency Oct 5, 2021
@junlincc junlincc added dashboard:colors Related to the color scheme of the Dashboard explore:colors Related to the color scheme in Explore labels Oct 6, 2021
@geido geido moved this from Issue to In review in Color consistency Oct 13, 2021
@geido geido moved this from In review to Merged in Color consistency Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report dashboard:colors Related to the color scheme of the Dashboard explore:colors Related to the color scheme in Explore preset:QA Preset QA team
Projects
Development

Successfully merging a pull request may close this issue.

3 participants