New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple refresh events when having multiple filters #170

Closed

gbrian opened this issue Mar 7, 2016 · 2 comments

Contributor

gbrian commented Mar 7, 2016

I guess there's an error when managing multiple filters. So I'll move slice.setFilter out from the loop, don't you?

Member

mistercrunch commented Mar 8, 2016

Good catch, yeah it should really just set the filter that has changed, I'm going to push a fix.

mistercrunch mentioned this issue

Fixing multiple refresh bug in filter_box #171

Merged

Contributor Author

gbrian commented Mar 8, 2016

Many thanks,
I still setting up dev environment and playing around.
Next time I'll try to create a PR.

gbrian closed this as completed

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          build(deps-dev): update terser-webpack-plugin requirement (apache#170)

dcf4ba0

Updates the requirements on [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) to permit the latest version.
- [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/terser-webpack-plugin@v1.3.0...v1.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          build(deps-dev): update terser-webpack-plugin requirement (apache#170)

8406ecf

Updates the requirements on [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) to permit the latest version.
- [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/terser-webpack-plugin@v1.3.0...v1.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          build(deps-dev): update terser-webpack-plugin requirement (apache#170)

f4d960c

Updates the requirements on [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) to permit the latest version.
- [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/terser-webpack-plugin@v1.3.0...v1.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          build(deps-dev): update terser-webpack-plugin requirement (apache#170)

5301cf8

Updates the requirements on [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) to permit the latest version.
- [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/terser-webpack-plugin@v1.3.0...v1.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment