fix(bigquery): calculated column cannot orderby in BigQuery

[zhaoyongjie]

SUMMARY

closed: #17178

Calculated column cannot use in native filter when using Google BigQuery. This is due to the column in ORDER BY must be in SELECT clause or GROUP BY clause.

added a new class property allows_hidden_cc_in_orderby in BaseEngineSpec to fix this error.

a calculated column in orderby

TESTING INSTRUCTIONS

Test this PR follow this issue: #17178

ADDITIONAL INFORMATION

• Has associated issue: [Native Filter] Not able to create dashboard native filter with calculated column #17178
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17196 (78fce8b) into master (824e62b) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #17196      +/-   ##
==========================================
- Coverage   76.93%   76.72%   -0.21%     
==========================================
  Files        1039     1039              
  Lines       55585    55592       +7     
  Branches     7578     7578              
==========================================
- Hits        42766    42655     -111     
- Misses      12569    12687     +118     
  Partials      250      250              

Flag	Coverage Δ
hive	?
mysql	81.92% <100.00%> (+<0.01%)	⬆️
postgres	81.93% <100.00%> (+<0.01%)	⬆️
presto	?
python	82.01% <100.00%> (-0.41%)	⬇️
sqlite	81.60% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/connectors/sqla/models.py	85.84% <100.00%> (-1.51%)	⬇️
superset/db_engine_specs/base.py	88.20% <100.00%> (-0.37%)	⬇️
superset/db_engine_specs/bigquery.py	84.84% <100.00%> (+0.09%)	⬆️
superset/db_engines/hive.py	0.00% <0.00%> (-85.19%)	⬇️
superset/db_engine_specs/hive.py	69.76% <0.00%> (-17.06%)	⬇️
superset/db_engine_specs/presto.py	83.47% <0.00%> (-6.49%)	⬇️
superset/views/database/mixins.py	81.03% <0.00%> (-1.73%)	⬇️
superset/models/core.py	89.26% <0.00%> (-0.74%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824e62b...78fce8b. Read the comment docs.

[villebro]

Oh man, this is definitely a bug in the BQ query engine 🤦 This workaround should IMO preferably be placed in the BQ SQLA dialect. I wonder if we should open a ticket there to get this fixed upstream, i.e. have the dialect ensure that the alias is used instead of the full expression? In the meantime this is a great workaround, thanks for fixing! Tested to work as expected, LGTM!

[rosemarie-chiu]

This is awesome! Thank you!

[sadpandajoe]

🏷️ 2021.42