Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI is blocked by mypy checking #17213

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

currently, CI is blocked by mypy checking in pre-commit. This PR unblock it

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #17213 (73099c5) into master (b5246b2) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17213      +/-   ##
==========================================
- Coverage   76.94%   76.72%   -0.22%     
==========================================
  Files        1039     1039              
  Lines       55608    55608              
  Branches     7580     7580              
==========================================
- Hits        42786    42667     -119     
- Misses      12572    12691     +119     
  Partials      250      250              
Flag Coverage Δ
hive ?
mysql 81.92% <0.00%> (ø)
postgres 81.93% <0.00%> (ø)
presto ?
python 82.01% <0.00%> (-0.42%) ⬇️
sqlite 81.60% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/utils.py 28.57% <0.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 69.76% <0.00%> (-17.06%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.49%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 85.84% <0.00%> (-1.64%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 90.02% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5246b2...73099c5. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit 31085e3 into apache:master Oct 25, 2021
@villebro
Copy link
Member

I wonder how this sneaked in? Apparently the version of mypy isn't pinned on pre-commit?

@zhaoyongjie
Copy link
Member Author

I wonder how this sneaked in? Apparently the version of mypy isn't pinned on pre-commit?

I am wired that we don't change mypy rev in the .pre-commit-cofig.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants