Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add possibility to set ingress class name in Helm chart #17252

Merged
merged 2 commits into from
Oct 28, 2021
Merged

feat: add possibility to set ingress class name in Helm chart #17252

merged 2 commits into from
Oct 28, 2021

Conversation

Jolcik
Copy link
Contributor

@Jolcik Jolcik commented Oct 27, 2021 •
edited

SUMMARY

Adds the possibility to set ingress class name in Helm chart. See: #17085

ADDITIONAL INFORMATION

  • Has associated issue: Helm chart / values.yaml should support specifying ingressClassName #17085
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

dpgaspar
dpgaspar reviewed Oct 28, 2021
View reviewed changes
helm/superset/values.yaml Outdated
@@ -165,6 +165,7 @@ service:

ingress:
enabled: false
# ingressClassName: nginx
annotations: {}
# kubernetes.io/ingress.class: nginx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is deprecated let's just remove the comment or add a deprecation notice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, removed the comment, thanks

@dpgaspar
Copy link
Member

Thank you for the contribution @Jolcik!

@dpgaspar dpgaspar merged commit 37909aa into apache:master Oct 28, 2021
@craig-rueda craig-rueda mentioned this pull request Oct 28, 2021
Closed
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jolcik @dpgaspar @mistercrunch