Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow users to update database in Dataset Edit Modal #17265

Merged
merged 2 commits into from
Oct 29, 2021
Merged

fix: Allow users to update database in Dataset Edit Modal #17265

merged 2 commits into from
Oct 29, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 28, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 28, 2021 •
edited
Loading

Codecov Report

Merging #17265 (8de2ff3) into master (93f59e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17265   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files        1037     1037           
  Lines       55626    55627    +1     
  Branches     7594     7595    +1     
=======================================
+ Hits        42849    42850    +1     
  Misses      12527    12527           
  Partials      250      250
Flag Coverage Δ
hive 81.52% <ø> (ø)
javascript 71.15% <100.00%> (+<0.01%) ⬆️
mysql 81.95% <ø> (ø)
postgres 81.96% <ø> (ø)
presto 81.83% <ø> (ø)
python 82.46% <ø> (ø)
sqlite 81.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/Datasource/DatasourceEditor.jsx 76.17% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f59e0...8de2ff3. Read the comment docs.

@hughhhh
Copy link
Member Author

hughhhh commented Oct 28, 2021

/testenv up

@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment spinning up at http://18.236.164.85:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@betodealmeida
Copy link
Member

@hughhhh I tested and it works. Let's merge this to unblock Max, but we need to add unit tests and make it more resilient.

Right now if you change the DB the user can still save the dataset even if the schema and table name are empty, which is bad.

@betodealmeida betodealmeida merged commit d0bad96 into master Oct 29, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Nov 1, 2021
@hughhhh @sadpandajoe
fix: Allow users to update database in Dataset Edit Modal (apache#17265)
983f7ff 
* add condition to fix save

* remove console.log

(cherry picked from commit d0bad96)
@sadpandajoe
Copy link
Member

🏷️ 2021.42

@eschutho eschutho added the v1.4 label Nov 22, 2021
eschutho pushed a commit that referenced this pull request Nov 22, 2021
@hughhhh @eschutho
fix: Allow users to update database in Dataset Edit Modal (#17265)
30c6ec0 
* add condition to fix save

* remove console.log

(cherry picked from commit d0bad96)
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@hughhhh @AAfghahi
fix: Allow users to update database in Dataset Edit Modal (#17265)
7dd6239 
* add condition to fix save

* remove console.log
@vnktsh
Copy link

vnktsh commented Mar 17, 2022

Does this fix #15733 ?

@rusackas rusackas mentioned this pull request Jan 20, 2023
Closed
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix-picking-db branch March 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.42 size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hughhhh @betodealmeida @sadpandajoe @vnktsh @mistercrunch @eschutho