fix(superset.cli): superset cli group doesn't support superset extension app #17539
Conversation
ofekisr
force-pushed
the
fix/superset_cli_app_loading
branch
from
9e2be0e
to
e0e54f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #17539 +/- ##
==========================================
- Coverage 76.81% 76.79% -0.03%
==========================================
Files 1049 1049
Lines 56653 56652 -1
Branches 7847 7847
==========================================
- Hits 43517 43504 -13
- Misses 12883 12895 +12
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…to fix/superset_cli_app_loading
done |
| @@ -34,7 +34,9 @@ assists people when migrating to a new version. | |||
| ### Potential Downtime | |||
|
|
|||
| - [16756](https://github.com/apache/incubator-superset/pull/16756): a change which renames the `dbs.allow_csv_upload` column to `dbs.allow_file_upload` via a (potentially locking) DDL operation. | |||
|
|
|||
| - [17539](https://github.com/apache/superset/pull/17539): all Superset CLI commands | |||
There was a problem hiding this comment.
@ofekisr this change—though relevant for inclusion in UPDATING.md—should be housed under the "Breaking Changes" section as opposed to "Potential Downtime".
There was a problem hiding this comment.
How does it breaking change?
mistercrunch
added
🏷️ bot
SUMMARY
When you run the Superset app, the app is loaded via Flask. Flask determines how to load the app by the FLASK_APP env variable.
In case you would like to develop an app that extends Superset, you can extend the app creation by supplying alternative FLASK_APP value instead of FLASK_APP="superset.app:create_app()"
but the Superset Cli group ignores that value by passing a redundant argument to FlaskGroup.
When the create_app argument is missed, it creates the application the same way the app is created on running Flask app
so when I set alternative value for Flask_app I can run superset init on the extended superset app