Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(superset.cli): superset cli group doesn't support superset extension app #17539

Merged
merged 5 commits into from
Nov 26, 2021
Merged

fix(superset.cli): superset cli group doesn't support superset extension app #17539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0e54f1
fix: remove redundant argument
ofekisr Nov 24, 2021
4435486
Update .flaskenv
amitmiran137 Nov 24, 2021
d1b812c
add pr details into updateing.md
ofekisr Nov 24, 2021
a6048f3
Merge remote-tracking branch 'origin/fix/superset_cli_app_loading' in…
ofekisr Nov 24, 2021
8bc5e2c
add pr details into updateing.md
ofekisr Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion UPDATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ assists people when migrating to a new version.
### Potential Downtime

- [16756](https://github.com/apache/incubator-superset/pull/16756): a change which renames the `dbs.allow_csv_upload` column to `dbs.allow_file_upload` via a (potentially locking) DDL operation.

- [17539](https://github.com/apache/superset/pull/17539): all Superset CLI commands
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofekisr this change—though relevant for inclusion in UPDATING.md—should be housed under the "Breaking Changes" section as opposed to "Potential Downtime".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it breaking change?

(init, load_examples and etc) require setting the FLASK_APP environment variable
(which is set by default when .flaskenv is loaded)
### Deprecations

### Other
Expand Down
5 changes: 1 addition & 4 deletions superset/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
from flask_appbuilder.api import BaseApi

from superset import app, appbuilder, config, security_manager
from superset.app import create_app
from superset.extensions import celery_app, db
from superset.utils import core as utils
from superset.utils.celery import session_scope
Expand Down Expand Up @@ -73,9 +72,7 @@ def normalize_token(token_name: str) -> str:


@click.group(
cls=FlaskGroup,
create_app=create_app,
context_settings={"token_normalize_func": normalize_token},
cls=FlaskGroup, context_settings={"token_normalize_func": normalize_token},
)
@with_appcontext
def superset() -> None:
Expand Down