Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): remove redis xadd type ignore #17555

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Nov 25, 2021

SUMMARY

Fix failing lint error on master, apparently due to redis stubs having been updated 6 hours ago: python/typeshed#6368

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro changed the title fix(lint): fix unnecessary type ignore fix(lint): remove redis xadd type ignore Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #17555 (ac114da) into master (5a1c681) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17555      +/-   ##
==========================================
- Coverage   77.03%   76.81%   -0.22%     
==========================================
  Files        1049     1049              
  Lines       56671    56671              
  Branches     7851     7851              
==========================================
- Hits        43655    43534     -121     
- Misses      12763    12884     +121     
  Partials      253      253              
Flag Coverage Δ
hive ?
mysql 82.02% <0.00%> (ø)
postgres 82.03% <0.00%> (ø)
presto ?
python 82.11% <0.00%> (-0.42%) ⬇️
sqlite 81.71% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/async_query_manager.py 82.24% <0.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.89%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.15% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1c681...ac114da. Read the comment docs.

@villebro villebro merged commit 7429282 into apache:master Nov 25, 2021
@villebro villebro mentioned this pull request Nov 25, 2021
9 tasks
@villebro villebro deleted the villebro/fix-pre-commit branch November 26, 2021 08:34
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants