Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update redis stubs to version 4 #6368

Merged
merged 10 commits into from
Nov 25, 2021
Merged

Update redis stubs to version 4 #6368

merged 10 commits into from
Nov 25, 2021

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Nov 23, 2021 •
edited by Akuli
Loading

This is incomplete:

  • Not all commands were moved to the command classes.
  • A few new modules are missing.
  • New commands are missing.

Closes: #6364

@srittau
Copy link
Collaborator Author

srittau commented Nov 23, 2021

Closes: #6364

Akuli
Akuli reviewed Nov 23, 2021
View reviewed changes
stubs/redis/redis/client.pyi Show resolved Hide resolved
stubs/redis/redis/client.pyi Outdated Show resolved Hide resolved
stubs/redis/redis/commands/core.pyi Outdated Show resolved Hide resolved
Akuli
Akuli approved these changes Nov 25, 2021
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't read in detail, but no red flags.

@Akuli Akuli merged commit ab026bf into python:master Nov 25, 2021
@srittau srittau deleted the redis-4 branch November 25, 2021 09:15
@sobolevn sobolevn mentioned this pull request Nov 25, 2021
Closed
@villebro villebro mentioned this pull request Nov 25, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis-py version 4
2 participants
@srittau @Akuli