Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alembic): Making Alembic logger config optional #17774

Merged

Conversation

craig-rueda
Copy link
Member

SUMMARY

The default Alembic env.py file explicitly loads its own logger configuration, which overwrites any other settings that users may have set elsewhere. This PR adds an optional envvar that can be used to disable this behavior.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #17774 (54a9331) into master (71e4131) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17774      +/-   ##
==========================================
- Coverage   67.71%   67.71%   -0.01%     
==========================================
  Files        1605     1605              
  Lines       64198    64200       +2     
  Branches     6790     6790              
==========================================
+ Hits        43474    43475       +1     
- Misses      18868    18869       +1     
  Partials     1856     1856              
Flag Coverage Δ
hive 81.79% <33.33%> (-0.01%) ⬇️
mysql 82.17% <33.33%> (-0.01%) ⬇️
postgres 82.22% <33.33%> (-0.01%) ⬇️
python 82.56% <33.33%> (-0.01%) ⬇️
sqlite 81.90% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/migrations/env.py 0.00% <0.00%> (ø)
superset/config.py 91.63% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e4131...54a9331. Read the comment docs.

@craig-rueda craig-rueda merged commit b3db614 into apache:master Dec 16, 2021
@craig-rueda craig-rueda deleted the craig/make-alembic-logging-optional branch December 16, 2021 00:17
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* Making Alembic logger config optional

* Switching to app config
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* Making Alembic logger config optional

* Switching to app config
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants