Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): update native filter info in metadata is not updated #17842

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR fixes the problem that native filter is not displayed correctly after the user updates native filter information via json editor.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

dashboard.propterties.mov

after

2021-12-21.10.03.27.mov

TESTING INSTRUCTIONS

follow #17665

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #17842 (4542055) into master (5b0aa27) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Current head 4542055 differs from pull request most recent head 629e3db. Consider uploading reports for the commit 629e3db to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17842      +/-   ##
==========================================
- Coverage   67.15%   67.03%   -0.13%     
==========================================
  Files        1608     1608              
  Lines       64798    64819      +21     
  Branches     6851     6852       +1     
==========================================
- Hits        43518    43451      -67     
- Misses      19421    19509      +88     
  Partials     1859     1859              
Flag Coverage Δ
hive ?
javascript 53.84% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns/legacy-plugin-chart-horizon/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...acy-plugin-chart-paired-t-test/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...gin-chart-parallel-coordinates/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...legacy-plugin-chart-partition/src/controlPanel.tsx 25.00% <0.00%> (-8.34%) ⬇️
...egacy-plugin-chart-pivot-table/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx 50.00% <0.00%> (-50.00%) ⬇️
...ns/legacy-plugin-chart-treemap/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...gacy-preset-chart-nvd3/src/DistBar/controlPanel.ts 10.00% <0.00%> (-1.12%) ⬇️
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 95.83% <0.00%> (-4.17%) ⬇️
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 40.00% <0.00%> (-10.00%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b0aa27...629e3db. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@villebro villebro merged commit ec48dd5 into apache:master Dec 22, 2021
@eschutho eschutho added the v1.4 label Jan 7, 2022
eschutho pushed a commit that referenced this pull request Jan 12, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants