Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native filter] edit native filter info in metadata in dashboard edit will move filter to out of scope #17932

Closed
2 of 3 tasks
jinghua-qa opened this issue Jan 5, 2022 · 2 comments
Labels
#bug Bug report inactive Inactive for >= 30 days preset:QA Preset QA team preset-io

Comments

@jinghua-qa
Copy link
Member

edit native filter description or filter name in metadata in dashboard edit will move filter out of scope

How to reproduce the bug

  1. create a native filter and apply for all scopes
  2. in dashboard edit mode, edit native filter description or filter name
  3. save the changes
  4. See error

Expected results

in metadata, edit native filter description or filter name did not change the scope

Actual results

in metadata, edit native filter description or filter name move native filter to out of scope

Screenshots

Screen.Recording.2022-01-05.at.12.01.48.AM.mov

Environment

(please complete the following information):

  • browser type and version:
  • superset version: master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@jinghua-qa jinghua-qa added the #bug Bug report label Jan 5, 2022
@jinghua-qa
Copy link
Member Author

jinghua-qa commented Jan 5, 2022

@stephenLYZ I think this may related to this PR, can you take a look of the issue

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report inactive Inactive for >= 30 days preset:QA Preset QA team preset-io
Projects
None yet
Development

No branches or pull requests

2 participants