fix(dashboard): scope status of filter not update in dashboard metadata #17945

stephenLYZ · 2022-01-06T07:32:12Z

SUMMARY

This PR fixes the problem that the scope status of filter which adds to the dashboard is not updated in the dashboard json metadata, steps to reproduce:

add a nativeFilter to the dashboard
edit dashboard and see the json metadata
metadata don't have field chartsInScope and filterConfig

It will cause the incorrect scope status if we update the native filter via json metadata like this issue #17932

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-01-06.3.28.18.mov

after

2022-01-06.3.30.39.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue: Fixes [native filter] edit native filter info in metadata in dashboard edit will move filter to out of scope #17932
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2022-01-06T09:31:00Z

Codecov Report

Merging #17945 (cdcfefa) into master (9e69940) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #17945      +/-   ##
==========================================
- Coverage   67.07%   67.06%   -0.02%     
==========================================
  Files        1609     1609              
  Lines       64905    64915      +10     
  Branches     6868     6869       +1     
==========================================
  Hits        43537    43537              
- Misses      19502    19512      +10     
  Partials     1866     1866

Flag	Coverage Δ
javascript	`53.75% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...et-frontend/src/dashboard/actions/nativeFilters.ts	`41.83% <0.00%> (-4.76%)`	⬇️
superset-frontend/src/common/components/index.tsx	`100.00% <0.00%> (ø)`
.../plugins/legacy-preset-chart-nvd3/src/Bar/index.js	`66.66% <0.00%> (ø)`
...gins/legacy-preset-chart-nvd3/src/DistBar/index.js	`66.66% <0.00%> (ø)`
...mponents/nativeFilters/FiltersConfigModal/state.ts	`73.33% <0.00%> (ø)`
...et-frontend/src/common/hooks/apiResources/index.ts
...nd/src/common/hooks/useComponentDidUpdate/index.ts
...set-frontend/src/common/hooks/usePrevious/index.ts
...uperset-frontend/src/components/Menu/MenuRight.tsx
...t-frontend/src/common/hooks/apiResources/charts.ts
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e69940...cdcfefa. Read the comment docs.

jinghua-qa · 2022-01-07T02:27:45Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true FEATURE_UX_BETA=true

github-actions · 2022-01-07T02:29:54Z

@jinghua-qa Ephemeral environment spinning up at http://54.187.239.26:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jinghua-qa · 2022-01-07T02:47:35Z

Stephen I have tested the PR in the env, i saw some issues
1, when i create a native filter, it put the filter out of scope even i selected all scope
2, the edit in metadata fornative filters seems not stay
Here is the video
https://user-images.githubusercontent.com/81597121/148483193-14bb16e7-f624-408a-b5ff-ef75d25ae941.mov

rusackas

LGTM! @jinghua-qa if you could give this a test bashing before we merge, that would be great!

rusackas · 2022-01-08T00:17:44Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true FEATURE_UX_BETA=true

github-actions · 2022-01-08T00:21:52Z

@rusackas Ephemeral environment spinning up at http://54.212.84.149:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jinghua-qa

LGTM

github-actions · 2022-01-10T17:20:02Z

Ephemeral environment shutdown and build artifacts deleted.

…ta (apache#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save (cherry picked from commit bd9e123)

rosemarie-chiu · 2022-01-10T23:09:50Z

🏷 2022.1

…ta (#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save

…ta (apache#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save

fix(dashboard): scope status of filter not update in dashboard metadata

6bac40b

pull-request-size bot added the size/XS label Jan 6, 2022

stephenLYZ closed this Jan 6, 2022

stephenLYZ reopened this Jan 6, 2022

fix save

cdcfefa

pull-request-size bot added size/S and removed size/XS labels Jan 7, 2022

jinghua-qa added the need:qa-review Requires QA review label Jan 7, 2022

rusackas approved these changes Jan 8, 2022

View reviewed changes

jinghua-qa approved these changes Jan 8, 2022

View reviewed changes

rusackas merged commit bd9e123 into apache:master Jan 10, 2022

superset-github-bot bot added the preset:2022.1 label Jan 10, 2022

eschutho added the v1.4 label Jan 13, 2022

eschutho pushed a commit that referenced this pull request Jan 13, 2022

fix(dashboard): scope status of filter not update in dashboard metada…

fbc81d7

…ta (#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022

fix(dashboard): scope status of filter not update in dashboard metada…

25e8ff4

…ta (apache#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save

bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022

fix(dashboard): scope status of filter not update in dashboard metada…

42e3eb4

…ta (apache#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save

mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dashboard): scope status of filter not update in dashboard metadata #17945

fix(dashboard): scope status of filter not update in dashboard metadata #17945

stephenLYZ commented Jan 6, 2022 •

edited by rusackas

codecov bot commented Jan 6, 2022 •

edited

jinghua-qa commented Jan 7, 2022

github-actions bot commented Jan 7, 2022

jinghua-qa commented Jan 7, 2022

rusackas left a comment

rusackas commented Jan 8, 2022

github-actions bot commented Jan 8, 2022

jinghua-qa left a comment

github-actions bot commented Jan 10, 2022

rosemarie-chiu commented Jan 10, 2022

fix(dashboard): scope status of filter not update in dashboard metadata #17945

fix(dashboard): scope status of filter not update in dashboard metadata #17945

Conversation

stephenLYZ commented Jan 6, 2022 • edited by rusackas

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

after

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Jan 6, 2022 • edited

Codecov Report

jinghua-qa commented Jan 7, 2022

github-actions bot commented Jan 7, 2022

jinghua-qa commented Jan 7, 2022

rusackas left a comment

Choose a reason for hiding this comment

rusackas commented Jan 8, 2022

github-actions bot commented Jan 8, 2022

jinghua-qa left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 10, 2022

rosemarie-chiu commented Jan 10, 2022

stephenLYZ commented Jan 6, 2022 •

edited by rusackas

codecov bot commented Jan 6, 2022 •

edited