Copy to clipboard fails in safari

[nytai]

For some actions the copy to clipboard action fails in safari. It appears that safari has strict security measures in place for the copy api. The copy api cannot be called from an api response and must be called from a user interaction (a DOM callback event). This is causing actions in superset that follow the pattern of call some api (usually to save some value) then copy the api response to clipboard to fail. The error message that's thrown suggest using cmd/ctrl + c to copy the value, however the value is not stored anywhere the user can highlight and copy.

How to reproduce the bug

1. Open Safari browser
2. Go to SQL Lab > SQL Editor
3. Click "Copy Link" button
4. See error

Expected results

Results are copied to clipboard or an acceptable workaround is presented to the user, such as displaying the value that should have been copied so the user can highly and cmd/ctrl + c the value.

Actual results

Copy to clipboard fails, an toast is thrown "Sorry, your browser does not support copying. Use Ctrl / Cmd + C!", and the user is unable to copy the value to clipboard

Screenshots

Environment

(please complete the following information):

• browser type and version: Safari (latest)
• superset version: 1.4.0
• python version: 3.8.12
• node.js version: N/A (using prebuilt assets)
• any feature flags active: N/A

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

[nytai]

It seems a way around this is store the returned value in the DOM somehow and add a copy to clipboard button which should work. If that doesn't work, at the very least the value is stored somewhere the user can highlight and cmd/ctrl + c manually. This fallback could be called when the copyTextToClipboard action fails (the promise rejects)

[nytai]

I suppose an even easier fix (though a little annoying) would be to add the copy text to the failure toast, then the user could just copy the value manually from there.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[nytai]

should be fixed by #20058

[isabellalacerda]

Copying doesn't work in any browser for me. How can i fix this?