more css fixes #182
Merged
more css fixes #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t control toggle interaction nicer. make sure user-stylesheets are applied last. remove ace css editor error/warning parsing. make filters look nicer in dashboards. fix some linting.
| @@ -149,7 +149,8 @@ var Dashboard = function (dashboardData) { | |||
| editor.setTheme("ace/theme/crimson_editor"); | |||
| editor.setOptions({ | |||
| minLines: 16, | |||
| maxLines: Infinity | |||
| maxLines: Infinity, | |||
| useWorker: false | |||
There was a problem hiding this comment.
this is the flag for not watching errors.
|
hmm not sure what's up with the travis build, |
|
Nice! LGTM |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
* feat: support locale in number and time format * test: improve coverage * test: merge js and ts test
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* feat: support locale in number and time format * test: improve coverage * test: merge js and ts test
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* feat: add india to country_map visualization India, through a merge conflict of some sort had been left out in the main repo when country_map was migrated to this repo. As part of the 0.34.0rc1 release process, this file got flagged as a potential license issue. Moving it out of the source release and here is the right thing to do. * docs: enable country map * fix: import india * build: disable geojson parsing * fix: import * build: disable country map storybook
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* feat: support locale in number and time format * test: improve coverage * test: merge js and ts test
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* feat: add india to country_map visualization India, through a merge conflict of some sort had been left out in the main repo when country_map was migrated to this repo. As part of the 0.34.0rc1 release process, this file got flagged as a potential license issue. Moving it out of the source release and here is the right thing to do. * docs: enable country map * fix: import india * build: disable geojson parsing * fix: import * build: disable country map storybook
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* feat: support locale in number and time format * test: improve coverage * test: merge js and ts test
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* feat: add india to country_map visualization India, through a merge conflict of some sort had been left out in the main repo when country_map was migrated to this repo. As part of the 0.34.0rc1 release process, this file got flagged as a potential license issue. Moving it out of the source release and here is the right thing to do. * docs: enable country map * fix: import india * build: disable geojson parsing * fix: import * build: disable country map storybook
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* feat: support locale in number and time format * test: improve coverage * test: merge js and ts test
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* feat: add india to country_map visualization India, through a merge conflict of some sort had been left out in the main repo when country_map was migrated to this repo. As part of the 0.34.0rc1 release process, this file got flagged as a potential license issue. Moving it out of the source release and here is the right thing to do. * docs: enable country map * fix: import india * build: disable geojson parsing * fix: import * build: disable country map storybook
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch
changes with this commit:
will work on the modal z-index separately, wanted to get these in.