feat: embedded dashboard #18561
Merged
feat: embedded dashboard #18561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18561 +/- ##
==========================================
- Coverage 66.30% 66.12% -0.19%
==========================================
Files 1595 1595
Lines 62629 62629
Branches 6308 6308
==========================================
- Hits 41527 41412 -115
- Misses 19453 19568 +115
Partials 1649 1649
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lilykuang
force-pushed
the
embedded-dashboard
branch
from
77533f2
to
84ba926
Compare
suddjian
reviewed
Feb 7, 2022
| sa.Column("created_on", sa.DateTime(), nullable=True), | ||
| sa.Column("changed_on", sa.DateTime(), nullable=True), | ||
| sa.Column("allow_domain_list", sa.Text(), nullable=True), | ||
| sa.Column("id", sa.Integer(), nullable=False), |
There was a problem hiding this comment.
Let's make the id column a uuid
added 2 commits
February 7, 2022 11:01
ofekisr
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 8, 2022
* add embedded dashboard * json * lint * change json to text * uuid
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Part of #17187
Every dashboard is considered embedded right now. We'll need to change some of the functions in security manager and the dashboard filter. This table is to keep track which dashboard is embedded.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION