Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Position of arrows in Table chart #18739

Merged
merged 4 commits into from
Feb 22, 2022
Merged

fix: Position of arrows in Table chart #18739

merged 4 commits into from
Feb 22, 2022

Conversation

geido
Copy link
Member

@geido geido commented Feb 15, 2022

SUMMARY

Fixes the position of the arrows in the Table chart

BEFORE

Screen Shot 2022-02-15 at 13 27 57

AFTER

Table chart AFTER

TESTING INSTRUCTIONS

  1. Open a Table chart
  2. Add several columns
  3. Make sure the cells are aligned correctly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #18739 (19a4823) into master (5bb406b) will increase coverage by 0.04%.
The diff coverage is 89.17%.

❗ Current head 19a4823 differs from pull request most recent head a3af166. Consider uploading reports for the commit a3af166 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18739      +/-   ##
==========================================
+ Coverage   66.32%   66.36%   +0.04%     
==========================================
  Files        1620     1620              
  Lines       63060    63042      -18     
  Branches     6368     6375       +7     
==========================================
+ Hits        41823    41840      +17     
+ Misses      19579    19543      -36     
- Partials     1658     1659       +1     
Flag Coverage Δ
javascript 51.25% <75.92%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js 0.00% <ø> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 33.33% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 33.33% <ø> (ø)
...rt-echarts/src/Timeseries/Regular/controlPanel.tsx 33.33% <ø> (ø)
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 28.57% <ø> (ø)
...ugin-chart-echarts/src/Timeseries/controlPanel.tsx 28.57% <ø> (ø)
...tend/plugins/plugin-chart-table/src/TableChart.tsx 38.57% <ø> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.73% <ø> (ø)
superset-frontend/src/chart/chartAction.js 53.79% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb406b...a3af166. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.210.87.129:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the styles clean up! LGTM!

@geido geido merged commit a9a8929 into apache:master Feb 22, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants