fix(chart): deprecate persisting url_params

[villebro]

SUMMARY

Currently there are a few problems in Explore view:

• if url_params are present in chart metadata, it's impossible to set new URL params to a chart in Explore view
• When saving a chart, the following error toast is emitted: "Form data not found in cache, reverting to chart metadata.". See screenshot below:
  

This PR changes how the hidden control url_params is handled by no longer be persisting it in chart metadata or cached chart form data. This is done by changing the following:

• Remove the error message about form data missing from cache if form_data_key is not present in the URL (sort of unrelated, but a regression nonetheless).
• Remove the url_params property from form_data if present before saving chart metadata
• Adds the removed url_params back to the URL during saving in the frontend so that the reloaded Explore/Dashboard view will retain the URL params that were present before saving chart metadata
• Adds an integration test for CreateChartCommand (bycatch - it was missing) and updates related unit tests

Note that charts that currently rely on default URL params that are persisted in chart data will still work like before - however, when the chart is saved/overwritten, the url_params state will be lost. So when making changes to old charts that are using the url_param function in templating code and haven't set default value as the second argument, users will need to update the url_param call to include the default value.

TESTING INSTRUCTIONS

1. enable ENABLE_TEMPLATE_PROCESSING feature flag
2. Crete a new chart using the flights dataset
3. Add a groupby for AIRLINE, a metric for COUNT(*) and a filter for AIRLINE IN ('{{ url_param('test') }}')
4. Add the param test=AA to the URL
5. Save chart
6. See error toast (no longer happens after PR)
7. remove the URL param and reload the chart
8. Notice that the URL param test=AA reappears (no longer happens after PR)

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #18960 (2d32d04) into master (7e336d1) will decrease coverage by 0.00%.
The diff coverage is 52.94%.

❗ Current head 2d32d04 differs from pull request most recent head 42805dd. Consider uploading reports for the commit 42805dd to get more accurate results

@@            Coverage Diff             @@
##           master   #18960      +/-   ##
==========================================
- Coverage   66.40%   66.39%   -0.01%     
==========================================
  Files        1641     1641              
  Lines       63518    63522       +4     
  Branches     6422     6422              
==========================================
- Hits        42176    42174       -2     
- Misses      19681    19687       +6     
  Partials     1661     1661              

Flag	Coverage Δ
hive	52.59% <16.66%> (-0.01%)	⬇️
mysql	81.83% <16.66%> (-0.01%)	⬇️
postgres	81.86% <16.66%> (-0.02%)	⬇️
presto	52.44% <16.66%> (-0.01%)	⬇️
python	82.30% <16.66%> (-0.02%)	⬇️
sqlite	81.57% <16.66%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...perset-frontend/src/addSlice/AddSliceContainer.tsx	61.76% <ø> (ø)
superset/views/core.py	77.39% <0.00%> (-0.12%)	⬇️
...lugin-chart-echarts/src/Timeseries/transformers.ts	51.23% <33.33%> (ø)
...rset-frontend/src/explore/exploreUtils/formData.ts	83.33% <75.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx	64.22% <100.00%> (+0.59%)	⬆️
...rset-frontend/src/explore/components/SaveModal.tsx	66.12% <100.00%> (ø)
superset/charts/commands/export.py	94.11% <100.00%> (ø)
superset/reports/commands/log_prune.py	85.71% <0.00%> (-3.58%)	⬇️
superset/commands/importers/v1/utils.py	89.13% <0.00%> (-2.18%)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e336d1...42805dd. Read the comment docs.

[michael-s-molina]

LGTM. Left a non-blocking suggestion.

[michael-s-molina]

@zhaoyongjie Since you know this feature better, can you also review it and make sure I didn't forget anything?

[zhaoyongjie]

Hey @villebro @michael-s-molina

Thanks for the fix. I tested all scenarios based on this PR, and it works fine!

1. url_params was removed when I created a chart on the master branch and switch to the current PR.
2. url_params was removed if I create a chart from the current branch.

But now the problem is, we can't find the original form_data_key anymore. This means that every time Chart is opened, a new form_data_key is generated. I would hear your thoughts.

[sadpandajoe]

🏷️ preset:2022.9