Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages): Fixing users packages #18973

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

craig-rueda
Copy link
Member

SUMMARY

Quick fix to add missing __init__.py files in user packages. CC - @suddjian

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #18973 (e4baa95) into master (7e336d1) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

❗ Current head e4baa95 differs from pull request most recent head d5a2f98. Consider uploading reports for the commit d5a2f98 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18973      +/-   ##
==========================================
- Coverage   66.40%   66.39%   -0.01%     
==========================================
  Files        1641     1641              
  Lines       63518    63520       +2     
  Branches     6422     6422              
==========================================
- Hits        42176    42174       -2     
- Misses      19681    19685       +4     
  Partials     1661     1661              
Flag Coverage Δ
hive 52.60% <100.00%> (ø)
mysql 81.83% <100.00%> (ø)
postgres 81.87% <100.00%> (-0.02%) ⬇️
presto 52.44% <100.00%> (ø)
python 82.30% <100.00%> (-0.02%) ⬇️
sqlite 81.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/addSlice/AddSliceContainer.tsx 61.76% <ø> (ø)
...d/components/nativeFilters/FilterCard/ScopeRow.tsx 0.00% <0.00%> (ø)
superset/views/users/schemas.py 100.00% <ø> (ø)
...d/src/SqlLab/components/QueryAutoRefresh/index.jsx 61.29% <25.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 51.23% <33.33%> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <100.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 64.22% <100.00%> (+0.59%) ⬆️
superset/initialization/__init__.py 90.72% <100.00%> (ø)
superset/views/users/api.py 100.00% <100.00%> (ø)
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e336d1...d5a2f98. Read the comment docs.

@craig-rueda craig-rueda merged commit 5fc7adb into apache:master Mar 1, 2022
@craig-rueda craig-rueda deleted the craig/fixing-users-packages branch March 1, 2022 17:47
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 1, 2022
* Fixing users packages

* Linting me() fn

* Fixing tests / moving packages

* Fixing imports

(cherry picked from commit 5fc7adb)
@sadpandajoe
Copy link
Member

🏷️ preset:2022.9

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Mar 2, 2022
* Fixing users packages

* Linting me() fn

* Fixing tests / moving packages

* Fixing imports

(cherry picked from commit 5fc7adb)
villebro pushed a commit that referenced this pull request Apr 3, 2022
* Fixing users packages

* Linting me() fn

* Fixing tests / moving packages

* Fixing imports

(cherry picked from commit 5fc7adb)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.9 preset-io size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants