Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbs-dropdown): make to allow the search in supported db dropdown #19125

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 11, 2022

SUMMARY

Update Supported Databases Dropdown to Allow Typeahead

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

How to reproduce bug

  1. Click to the Databases page
  2. Open the + Databases button
  3. Click to type in the dropdown search bar

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #19125 (5997cf6) into master (7524e1e) will not change coverage.
The diff coverage is n/a.

❗ Current head 5997cf6 differs from pull request most recent head c35d1ca. Consider uploading reports for the commit c35d1ca to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19125   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files        1646     1646           
  Lines       63540    63540           
  Branches     6466     6466           
=======================================
  Hits        42268    42268           
  Misses      19596    19596           
  Partials     1676     1676           
Flag Coverage Δ
javascript 51.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.90% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7524e1e...c35d1ca. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just wishing for this yesterday!!! What a simple yet impactful change. Thanks for the thorough PR description, too!

@rusackas rusackas merged commit 8e7af79 into apache:master Mar 16, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants