Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): make to show the correct owned objects #19372

Merged
merged 7 commits into from
Mar 31, 2022
Merged

fix(dashboard): make to show the correct owned objects #19372

merged 7 commits into from
Mar 31, 2022

Conversation

prosdev0107
Copy link
Contributor

SUMMARY

ReOpen: Making myself owner of a dashboard that was NOT created by me does not show in "Mine" tab on homepage
Relative PR: #19223

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
160086196-670d8724-2725-4ee1-8e4b-2853511264f5
AFTER:
image

TESTING INSTRUCTIONS

How to reproduce bugs

  1. Go To the Homepage!
  2. Error Toast message

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@prosdev0107 prosdev0107 mentioned this pull request Mar 25, 2022
Merged
9 tasks
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #19372 (7e65027) into master (2b53578) will not change coverage.
The diff coverage is n/a.

❗ Current head 7e65027 differs from pull request most recent head 164e563. Consider uploading reports for the commit 164e563 to get more accurate results

@@           Coverage Diff           @@
##           master   #19372   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files        1676     1676           
  Lines       64715    64715           
  Branches     6506     6506           
=======================================
  Hits        43151    43151           
  Misses      19878    19878           
  Partials     1686     1686
Flag Coverage Δ
javascript 51.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/utils.tsx 65.57% <ø> (ø)
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx 75.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b53578...164e563. Read the comment docs.

@villebro villebro mentioned this pull request Mar 31, 2022
Closed
9 tasks
villebro
villebro approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@villebro villebro merged commit 6d89ffb into apache:master Mar 31, 2022
@villebro villebro mentioned this pull request Mar 31, 2022
Closed
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 1, 2022
@prosdev0107 @sadpandajoe
fix(dashboard): make to show the correct owned objects (apache#19372)
61e4e03 
* fix(dashboard): make to show the correct owned objects

* fix(dashboard): make to filter is reusable

* fix(homepage): make sure the type Array<Filters>

* fix(homepage): make to display dashboard correctly by owners

(cherry picked from commit 6d89ffb)
villebro pushed a commit that referenced this pull request Apr 3, 2022
@prosdev0107 @villebro
fix(dashboard): make to show the correct owned objects (#19372)
7df3f76 
* fix(dashboard): make to show the correct owned objects

* fix(dashboard): make to filter is reusable

* fix(homepage): make sure the type Array<Filters>

* fix(homepage): make to display dashboard correctly by owners

(cherry picked from commit 6d89ffb)
villebro pushed a commit that referenced this pull request Apr 4, 2022
@prosdev0107 @villebro
fix(dashboard): make to show the correct owned objects (#19372)
e93d64d 
* fix(dashboard): make to show the correct owned objects

* fix(dashboard): make to filter is reusable

* fix(homepage): make sure the type Array<Filters>

* fix(homepage): make to display dashboard correctly by owners

(cherry picked from commit 6d89ffb)
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.13

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@prosdev0107 @philipher29
fix(dashboard): make to show the correct owned objects (apache#19372)
9801ff3 
* fix(dashboard): make to show the correct owned objects

* fix(dashboard): make to filter is reusable

* fix(homepage): make sure the type Array<Filters>

* fix(homepage): make to display dashboard correctly by owners
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomedina248 diegomedina248 diegomedina248 approved these changes

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.13 Preset-Patch size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prosdev0107 @sadpandajoe @diegomedina248 @villebro @mistercrunch