Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(welcome): saved queries causing error #19464

Closed
wants to merge 1 commit into from

Conversation

villebro
Copy link
Member

SUMMARY

A recent PR #19223 caused a regression due to trying to query for saved_query objects by their owners, despite the model only having a creator (there is no saved_query_user, like there is for dashboard_user for dashboards and slice_user for slices). This renames the getUserOwnedObjects to getUserObjects and adds a parameter filterBy which makes it possible to define whether or not to query by owners or created_by.

AFTER

After the change, the welcome page loads without errors:
image

BEFORE

Previously there was an error toast caused by a 400:
image

TESTING INSTRUCTIONS

  1. Go to welcome page
  2. Verify that the error no longer happens

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member Author

Closing as this is a duplicate of #19372

@villebro villebro closed this Mar 31, 2022
@villebro villebro deleted the villebro/fix-welcome branch March 31, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant