[WiP] Attempting to support Druid's granularity origin as a hidden url param #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
druid_origin
branch
from
6c28023
to
9efafa8
Compare
| @@ -214,6 +214,7 @@ def __init__(self, viz): | |||
| '6 hour', | |||
| '1 day', | |||
| '7 days', | |||
| # you could add a special string here | |||
There was a problem hiding this comment.
say if you'd write "1 week, ending on sunday" here, you'd have to capture that on the other side on the query method and translate it into a granularity dict
|
you'd have to append a |
mistercrunch
force-pushed
the
druid_origin
branch
from
9efafa8
to
616acbc
Compare
mistercrunch
force-pushed
the
druid_origin
branch
from
616acbc
to
1538cd4
Compare
| 'Origin', | ||
| choices=( | ||
| ('now', 'now'), | ||
| ('2016-04-10', 'even'), |
There was a problem hiding this comment.
@mistercrunch Should this be sunday? Also are the choices set to be static? I'd imagine it be useful to input any day of the week as the anchor and based on the input the date can be set
There was a problem hiding this comment.
yeah it's a bit weird because even can be used for lining up any granularity. Actually I should find a year where jan 1st was a Sunday. It'd work to line things up whether your granularity is minute, hour, day, sunday, year, ... I should probably put that in the tooltip.
mistercrunch
force-pushed
the
druid_origin
branch
from
1538cd4
to
bb8923f
Compare
|
Ok, I think this is looking good now! |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.