feat: Remove legacy sql alchemy db connection link from G Sheet connection #19450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19450 +/- ##
=======================================
Coverage 66.49% 66.49%
=======================================
Files 1681 1681
Lines 64370 64372 +2
Branches 6583 6584 +1
=======================================
+ Hits 42803 42805 +2
Misses 19886 19886
Partials 1681 1681
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| )} | ||
| viewBox="0 -6 24 24" | ||
| /> | ||
| {dbModel.name !== 'Google Sheets' && ( |
There was a problem hiding this comment.
can we check the engine against gsheets instead?
It's done like that in the same file, so if we can, we should use the same checking method.
And probably move that gsheets engine string to a constant.
diegomedina248
approved these changes
Apr 8, 2022
rusackas
approved these changes
Apr 14, 2022
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…ction (apache#19450) * feat: Remove legacy sql alchemy db connection link from G Sheet connection * resolve comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When we add google sheet as a database, we still have legacy SQLAlchemy url connection method, which is not supported anymore.
So removed this from the GSheet connection.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION