Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deck.gl): add color range for deck.gl 3D chart #19520

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Apr 4, 2022

SUMMARY

Currently deck.gl 3D Hexagon and deck.gl Grid cannot set the color of the extruded bar. Here we use color scheme control to give these two charts the ability to set colors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-04-05.12.46.27.mov

after

2022-04-05.12.44.21.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #19520 (b9dd681) into master (4b92287) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head b9dd681 differs from pull request most recent head b1917f3. Consider uploading reports for the commit b1917f3 to get more accurate results

@@            Coverage Diff             @@
##           master   #19520      +/-   ##
==========================================
- Coverage   66.59%   66.58%   -0.02%     
==========================================
  Files        1678     1680       +2     
  Lines       64242    64254      +12     
  Branches     6539     6539              
==========================================
+ Hits        42784    42785       +1     
- Misses      19763    19774      +11     
  Partials     1695     1695              
Flag Coverage Δ
javascript 51.33% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...legacy-plugin-chart-sunburst/src/ReactSunburst.jsx 0.00% <0.00%> (ø)
...ugins/legacy-plugin-chart-sunburst/src/Sunburst.js 0.00% <ø> (ø)
...s/legacy-plugin-chart-treemap/src/ReactTreemap.jsx 0.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-treemap/src/Treemap.js 0.00% <ø> (ø)
...egacy-preset-chart-deckgl/src/layers/Grid/Grid.jsx 0.00% <0.00%> (ø)
...reset-chart-deckgl/src/layers/Grid/controlPanel.ts 100.00% <ø> (ø)
.../legacy-preset-chart-deckgl/src/layers/Hex/Hex.jsx 0.00% <0.00%> (ø)
...preset-chart-deckgl/src/layers/Hex/controlPanel.ts 100.00% <ø> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
...src/components/FilterableTable/FilterableTable.tsx 71.42% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b92287...b1917f3. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://18.236.199.241:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@zhaoyongjie zhaoyongjie merged commit c0a00fd into apache:master Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

Ephemeral environment shutdown and build artifacts deleted.

akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants