fix: Show full long number in text email report for table chart. #19575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset/utils/csv.py
Outdated
| @@ -95,6 +98,9 @@ def get_chart_dataframe( | |||
| return None | |||
|
|
|||
| result = simplejson.loads(content.decode("utf-8")) | |||
| pd.set_option( | |||
| "display.float_format", lambda x: str(x) | |||
| ) # need to convert float value to string to show full long number | |||
There was a problem hiding this comment.
add the comment above the line:
# comm
pd.set_option...
diegomedina248
approved these changes
Apr 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #19575 +/- ##
=======================================
Coverage 66.54% 66.54%
=======================================
Files 1692 1692
Lines 64775 64804 +29
Branches 6661 6661
=======================================
+ Hits 43103 43125 +22
- Misses 19972 19979 +7
Partials 1700 1700
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
approved these changes
Apr 13, 2022
|
Approving (and re-starting CI... sigh). Heads up to @eschutho in case you have any additional feelings here. |
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
…che#19575) * fix lint issue * resolve comment * fix pipeline broken issue * resolve pipeline broken issue
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…che#19575) * fix lint issue * resolve comment * fix pipeline broken issue * resolve pipeline broken issue
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Before this update, when we have long number in text email report for table chart, report was not showing correct value.
It was because
pdconverts long float value intoetype.In this pr, we added some display viz option into
pd, so all long float value are displayed as a string.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
Check the email.
ADDITIONAL INFORMATION