Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database-api): allow search for all columns #19662

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Apr 12, 2022

SUMMARY

#19051 broke filtering databases by other than allow_file_upload and expose_in_sqllab, causing trouble in both SQL Lab and the database list view. This removes the list of explicit search_columns so that filtering by all properties is again possible.

AFTER

SQL Lab:
image

Database list view sorting by AQE:
image

BEFORE

SQL Lab:
image

Database list view:
image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: closes Filter column: database_name not allowed to filter #19655
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #19662 (47bce81) into master (5c63df5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19662      +/-   ##
==========================================
- Coverage   66.47%   66.47%   -0.01%     
==========================================
  Files        1681     1681              
  Lines       64468    64467       -1     
  Branches     6607     6607              
==========================================
- Hits        42857    42856       -1     
  Misses      19917    19917              
  Partials     1694     1694              
Flag Coverage Δ
hive 52.66% <ø> (-0.01%) ⬇️
mysql 81.90% <ø> (-0.01%) ⬇️
postgres 81.95% <ø> (-0.01%) ⬇️
presto 52.51% <ø> (-0.01%) ⬇️
python 82.39% <ø> (-0.01%) ⬇️
sqlite 81.72% <ø> (-0.01%) ⬇️
unit 47.71% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/api.py 94.01% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c63df5...47bce81. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my local. LGTM. the search column in FAB seems that it can't search boolean fields.

@villebro villebro merged commit 3a231f6 into apache:master Apr 12, 2022
@villebro villebro deleted the villebro/fix-db-perm branch April 12, 2022 10:51
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter column: database_name not allowed to filter
3 participants