Table Viz - Sorting by multiple columns no longer works

[stevetracvc]

A recent (Dec) commit to the table viz added something for case-insensitive sorting. Unfortunately, this also broke the ability to shift-click and sort by multiple columns.

How to reproduce the bug

1. Explore a table (or find one in a dashboard)
2. Click on the header of an alphanumeric column to sort by that column (make sure there are multiple rows with the same value for this column, eg Video Game Sales -> Overview -> Top 10 Games table, sort by platform column)
3. Shift click on any other column to also sort by that column (eg, global_sales column)
4. See that nothing changed

Expected results

Any rows with ties in the first column should then be sorted by the second column.

Actual results

It only sorts by the first column

Screenshots

unsorted:

Sorted by Platform

Sorted by Platform AND Global Sales (broken)

How it should sort

Environment

• superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

[rusackas]

I think this was fixed but never closed. Happy to reopen if I'm misinterpreting

[LeulAria]

what's the solution here ? didn't get the context
was implementing multiple sort, added
yet im getting single value in the array of sorts for the sorting state

{
   ...,
   state:  {
       sorting
   }
   manualSorting: true,
   enableMultiSort: true,
   onSortingChange: setSorting
}

[stevetracvc]

@LeulAria what version of superset are you using? I wrote a fix and it was merged a couple years ago.

You have to shift + click when picking columns for the multi sort, do you have the shift key bound to some other action?