Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing local variable response before initialiazing in get_chart_csv_data error handling #20262

Closed
3 tasks done
zhaorui2022 opened this issue Jun 3, 2022 · 2 comments
Closed
3 tasks done
Labels
#bug Bug report

Comments

@zhaorui2022
Copy link
Contributor

In this line, it is trying to access response before it is initialized if auth_cookies is false. Will send a PR after creating this issue.

How to reproduce the bug

  1. Run with an unauthorized user name to create an alert. When the alerts fails and tries to send a notification, it fails with error message Failed generating csv local variable 'response' referenced before assignment.

Expected results

If running with unauthorized user name, it should just fails to retrieve data.

Actual results

It fails with error message Failed generating csv local variable 'response' referenced before assignment

Screenshots

N/A

Environment

(please complete the following information):

  • browser type and version: It is a backend error and is happening to all browsers
  • superset version: superset version latest
  • python version: python --version 3.9
  • node.js version: node -v N/A
  • any feature flags active: N/A

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@zhaorui2022
Copy link
Contributor Author

PR: #20263

@rusackas
Copy link
Member

@zhaorui2022 thank you for resolving this!!! If there are any outstanding issues, just say the word, and we can re-open it. Let us know if we can assist you in any further contributions to Superset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants