fix(embedded): accessing variable response before initialization

[zhaorui2022]

SUMMARY

superset/superset/utils/csv.py

Line 83 in 4f77824

if response.getcode() != 200:

At line 83, if auth_cookies is false, before returning an URLError, line 83 will fail with error message saying Failed generating csv local variable 'response' referenced before assignment. More details reported at #20262

ADDITIONAL INFORMATION

• Has associated issue: Referencing local variable response before initialiazing in get_chart_csv_data error handling  #20262
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20263 (306aca4) into master (2a1dcaf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20263   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files        1726     1726           
  Lines       64886    64845   -41     
  Branches     6832     6832           
=======================================
- Hits        43168    43141   -27     
+ Misses      19986    19972   -14     
  Partials     1732     1732           

Flag	Coverage Δ
hive	53.70% <0.00%> (+0.04%)	⬆️
mysql	?
postgres	82.35% <100.00%> (+0.06%)	⬆️
presto	53.56% <0.00%> (+0.04%)	⬆️
python	82.73% <100.00%> (+0.02%)	⬆️
sqlite	82.08% <100.00%> (+0.06%)	⬆️
unit	50.15% <0.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/utils/csv.py	97.91% <100.00%> (ø)
superset/common/utils/dataframe_utils.py	85.71% <0.00%> (-7.15%)	⬇️
superset/db_engine_specs/mysql.py	93.97% <0.00%> (-3.62%)	⬇️
superset/models/core.py	88.43% <0.00%> (-0.73%)	⬇️
superset/views/core.py	76.88% <0.00%> (-0.46%)	⬇️
superset/databases/schemas.py	98.58% <0.00%> (+<0.01%)	⬆️
superset/jinja_context.py	91.15% <0.00%> (+0.32%)	⬆️
superset/db_engine_specs/trino.py	91.93% <0.00%> (+20.50%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a1dcaf...306aca4. Read the comment docs.