fix: Alpha are unable to perform a second modification to a Dataset when in Explore #20296
Conversation
| @@ -200,7 +200,8 @@ class DatasourceControl extends React.PureComponent { | |||
| const { user } = this.props; | |||
| const allowEdit = | |||
| datasource.owners.map(o => o.id).includes(user.userId) || | |||
| isUserAdmin(user); | |||
| datasource.owners.map(o => o.value).includes(user.userId); | |||
There was a problem hiding this comment.
couldn't you write this in without the ||
o => o.id || o.value == user.userId
There was a problem hiding this comment.
don't think this is the right way of doing it though.
There was a problem hiding this comment.
also should this be an || or should you be amending allowEdit with the new values from o.value?
|
/testenv up |
|
@hughhhh Ephemeral environment spinning up at http://54.149.174.139:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #20296 +/- ##
==========================================
- Coverage 66.65% 66.61% -0.05%
==========================================
Files 1729 1733 +4
Lines 64906 64953 +47
Branches 6842 6858 +16
==========================================
+ Hits 43266 43269 +3
- Misses 19891 19929 +38
- Partials 1749 1755 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
SUMMARY
Fix issue when Alpha users want to make a secondary change in
Edit Dataset. The issue lies with the API fromdatasource/savereturning a different payload for datasource.owners. To handle we'll add an additional check for the key value to make sure the user will still be able to edit moving forward.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION