feat: add extension point to the right side of the menu bar #20514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20514 +/- ##
=======================================
Coverage 66.71% 66.71%
=======================================
Files 1752 1752
Lines 65478 65482 +4
Branches 6916 6917 +1
=======================================
+ Hits 43681 43684 +3
- Misses 20049 20050 +1
Partials 1748 1748
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
samtfm
force-pushed
the
samtfm/add-setup-extensions
branch
from
9148d6f
to
79bd04e
Compare
suddjian
approved these changes
Jun 28, 2022
samtfm
force-pushed
the
samtfm/add-setup-extensions
branch
from
982a33c
to
8e8f9df
Compare
akshatsri
pushed a commit
to charan1314/superset
that referenced
this pull request
Jul 19, 2022
…0514) * add setupExtensions * add 'navbar.right' extension to registry * add test for navbar.right extension point * rename MenuRight -> RightMenu * lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
adds a file, setupExtensions.ts, for applying ui overrides to registered places
adds a registration point for adding components to the right side of the top nav bar.
TESTING INSTRUCTIONS
registering a component to the "navbar.right" registration key should cause that component to render to the left of the menu items on the right side of the nav bar.
ADDITIONAL INFORMATION