fix(import): Show the error message with db install guide when exist the importing db issue #20573
Conversation
| @@ -51,6 +51,7 @@ const ErrorAlert: FunctionComponent<IProps> = ({ | |||
| {t( | |||
| 'Database driver for importing maybe not installed. Visit the Superset documentation page for installation instructions:', | |||
| )} | |||
| | |||
There was a problem hiding this comment.
Wondering why not using css on the anchor or span to space out?
|
/testenv up |
Codecov Report
@@ Coverage Diff @@
## master #20573 +/- ##
==========================================
- Coverage 66.71% 66.68% -0.03%
==========================================
Files 1752 1754 +2
Lines 65478 65588 +110
Branches 6916 6935 +19
==========================================
+ Hits 43681 43740 +59
- Misses 20049 20092 +43
- Partials 1748 1756 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@yousoph Ephemeral environment spinning up at http://54.202.176.73:8080. Credentials are |
|
A few text updates needed: When the error shows up on the db connection screen, a period is also missing before "Please" |
|
@yousoph |
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://35.90.50.211:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
…the importing db issue (apache#20573) * fix(import): make to update the error display when importing resurce * fix(import): make to update the error message
…the importing db issue (apache#20573) * fix(import): make to update the error display when importing resurce * fix(import): make to update the error message
mistercrunch
added
🏷️ bot
SUMMARY
Add error message when user tries to import without having db driver installed
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
import-resource.mov
TESTING INSTRUCTIONS
In case of Invaid db file with already installed driver
In case of invaoide db fiel with not installed driver
ADDITIONAL INFORMATION