fix: Use cache_manager.cache rather than cache_manager.data_cache for caching table metadata

[john-bodley]

SUMMARY

The cache_manager.cache—the original catch-all cache which likely should be renames to cache_manager.metadata_cache—should be used for caching the table/view metadata as opposed to the cache_manager.data_cache which is used to cache non-metadata data.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20726 (93fe0a8) into master (c70d102) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 93fe0a8 differs from pull request most recent head b76ebd7. Consider uploading reports for the commit b76ebd7 to get more accurate results

@@            Coverage Diff             @@
##           master   #20726      +/-   ##
==========================================
- Coverage   66.84%   66.83%   -0.01%     
==========================================
  Files        1750     1750              
  Lines       65896    65896              
  Branches     7017     7017              
==========================================
- Hits        44048    44043       -5     
- Misses      20062    20067       +5     
  Partials     1786     1786              

Flag	Coverage Δ
hive	53.87% <ø> (ø)
mysql	82.47% <ø> (ø)
postgres	82.54% <ø> (ø)
presto	53.73% <ø> (ø)
python	82.98% <ø> (-0.02%)	⬇️
sqlite	82.35% <ø> (ø)
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/models/core.py	89.15% <ø> (ø)
superset/initialization/__init__.py	89.93% <0.00%> (-1.74%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70d102...b76ebd7. Read the comment docs.