Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use cache_manager.cache rather than cache_manager.data_cache for caching table metadata #20726

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: Use cache_manager.cache rather than cache_manager.data_cache for caching table metadata #20726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions superset/models/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ def inspector(self) -> Inspector:

@cache_util.memoized_func(
key="db:{self.id}:schema:None:table_list",
cache=cache_manager.data_cache,
cache=cache_manager.cache,
)
def get_all_table_names_in_database( # pylint: disable=unused-argument
self,
Expand All @@ -531,7 +531,7 @@ def get_all_table_names_in_database( # pylint: disable=unused-argument

@cache_util.memoized_func(
key="db:{self.id}:schema:None:view_list",
cache=cache_manager.data_cache,
cache=cache_manager.cache,
)
def get_all_view_names_in_database( # pylint: disable=unused-argument
self,
Expand All @@ -551,7 +551,7 @@ def get_all_view_names_in_database( # pylint: disable=unused-argument

@cache_util.memoized_func(
key="db:{self.id}:schema:{schema}:table_list",
cache=cache_manager.data_cache,
cache=cache_manager.cache,
)
def get_all_table_names_in_schema( # pylint: disable=unused-argument
self,
Expand Down Expand Up @@ -582,7 +582,7 @@ def get_all_table_names_in_schema( # pylint: disable=unused-argument

@cache_util.memoized_func(
key="db:{self.id}:schema:{schema}:view_list",
cache=cache_manager.data_cache,
cache=cache_manager.cache,
)
def get_all_view_names_in_schema( # pylint: disable=unused-argument
self,
Expand Down Expand Up @@ -613,7 +613,7 @@ def get_all_view_names_in_schema( # pylint: disable=unused-argument

@cache_util.memoized_func(
key="db:{self.id}:schema_list",
cache=cache_manager.data_cache,
cache=cache_manager.cache,
)
def get_all_schema_names( # pylint: disable=unused-argument
self,
Expand Down