Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reverts #20749 and #20645 #20796

Merged
merged 2 commits into from
Jul 20, 2022
Merged

fix: Reverts #20749 and #20645 #20796

merged 2 commits into from
Jul 20, 2022

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jul 20, 2022 •
edited

SUMMARY

Reverts #20749 and #20645 because of Redux state side-effects. We ended up finding some unwanted behavior when saving Explore charts. We'll work on a better Redux state definition with stronger type checking and try again 🤷‍♂️

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codyml codyml mentioned this pull request Jul 20, 2022
Closed
9 tasks
rusackas
rusackas approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock forward progress.

@michael-s-molina michael-s-molina merged commit 3311128 into apache:master Jul 20, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.29

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 21, 2022
@michael-s-molina @sadpandajoe
fix: Reverts apache#20749 and apache#20645 (apache#20796)
e4916de 
* Revert "fix: Error when saving datasource from Explore (apache#20749)"

This reverts commit 92f3621.

* Revert "refactor: Unify shared datasources reducers and actions (apache#20645)"

This reverts commit 2a70540.

(cherry picked from commit 3311128)
@codyml codyml mentioned this pull request Jul 29, 2022
Merged
9 tasks
@codyml codyml mentioned this pull request Sep 7, 2022
Closed
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@jinghua-qa jinghua-qa Awaiting requested review from jinghua-qa

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michael-s-molina @sadpandajoe @rusackas @mistercrunch