Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Unskip Cypress test #20915

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Jul 29, 2022

SUMMARY

This PR unskips the Cypress test that was temporarily skipped to allow #20699 to pass CI. The issue causing it to fail was fixed in #20796.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #20915 (bf4c223) into master (8d0d778) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20915   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files        1758     1758           
  Lines       67008    67008           
  Branches     7107     7107           
=======================================
  Hits        44437    44437           
  Misses      20749    20749           
  Partials     1822     1822           
Flag Coverage Δ
javascript 52.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 90460f1 into apache:master Jul 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants