fix(explore): Adhoc columns don't display correctly

[kgabryje]

SUMMARY

Fix adhoc columns not displaying properly. When user added an adhoc column the label was blank and on click an empty popover was showing up instead of prefilled with custom sql.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

1. Add an adhoc column
2. Verify that it displays correctly
3. Click on the column to edit
4. Verify that popover opens on Custom SQL tab with column's sql expression prefilled

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20802 (af14b8c) into master (3311128) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master   #20802   +/-   ##
=======================================
  Coverage   66.29%   66.30%           
=======================================
  Files        1758     1758           
  Lines       66799    66800    +1     
  Branches     7055     7056    +1     
=======================================
+ Hits        44286    44292    +6     
+ Misses      20713    20710    -3     
+ Partials     1800     1798    -2     

Flag	Coverage Δ
javascript	51.98% <66.66%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ackages/superset-ui-core/src/query/types/Column.ts	100.00% <ø> (ø)
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx	3.75% <0.00%> (ø)
...et-ui-chart-controls/src/components/labelUtils.tsx	100.00% <100.00%> (ø)
.../controls/DndColumnSelectControl/OptionWrapper.tsx	65.85% <0.00%> (+2.43%)	⬆️
...ols/DndColumnSelectControl/utils/optionSelector.ts	37.93% <0.00%> (+13.79%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

[zhaoyongjie]

looks good. Thanks for the fix.

[sadpandajoe]

🏷️ preset:2022.29