Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIP-90] Provides filter bar visibility setting on embedded dashboards #21069

Closed
jileeon opened this issue Aug 12, 2022 · 2 comments
Closed

[SIP-90] Provides filter bar visibility setting on embedded dashboards #21069

jileeon opened this issue Aug 12, 2022 · 2 comments
Labels
sip Superset Improvement Proposal 🚢 2.1.3
Projects
SIPs

Comments

@jileeon
Copy link
Contributor

jileeon commented Aug 12, 2022

[SIP-90] Proposal for Providing filter bar visibility setting on embedded dashboards

Motivation

Want to hide the native filter bar by default

Proposed Change

Control filter bar visibility by using query parameters which already been implemented. See #18741

New or Changed Public Interfaces

embedded-sdk supports them

New dependencies

N/A

Migration Plan and Compatibility

N/A

Rejected Alternatives

N/A
jileeon pushed a commit to jileeon/superset that referenced this issue Sep 1, 2022
@jileeon88
feat(embedded): provides filter bar visibility setting on embedded da…
f919201 
…shboard (apache#21069)
michael-s-molina pushed a commit that referenced this issue Sep 1, 2022
@jileeon @jileeon88
feat(embedded): provides filter bar visibility setting on embedded da…
eb80568 
…shboard (#21069) (#21070)

Co-authored-by: 이재익 [jileeon] <jileeon@nexon.co.kr>
eschutho pushed a commit that referenced this issue Sep 20, 2022
@jileeon @eschutho
feat(embedded): provides filter bar visibility setting on embedded da…
9b8c20e 
…shboard (#21069) (#21070)

Co-authored-by: 이재익 [jileeon] <jileeon@nexon.co.kr>
(cherry picked from commit eb80568)
AAfghahi pushed a commit that referenced this issue Oct 6, 2022
@jileeon @AAfghahi
feat(embedded): provides filter bar visibility setting on embedded da…
d62e7e7 
…shboard (#21069) (#21070)

Co-authored-by: 이재익 [jileeon] <jileeon@nexon.co.kr>
(cherry picked from commit eb80568)
@rusackas rusackas added this to PRE-DISCUSSION in SIPs Nov 30, 2022
@ShaliniIruvuru
Copy link

ShaliniIruvuru commented Mar 17, 2023 •
edited
Loading

We can hide the native filter bar visibility.It is working fine
Screenshot:-
Screenshot from 2023-03-22 19-53-34

@john-bodley john-bodley added the sip Superset Improvement Proposal label Jun 7, 2023
@rusackas
Copy link
Member

I'll close this as it seems to be resolved by https://github.com/apache/superset/pull/21070/files

CC @michael-s-molina (who reviewed the PR) and @john-bodley as fellow SIP-steward, for context.

@jileeon let me know if there's more work to be done as part of this SIP, and we can re-open it and start the discussion/voting process.

Hat tip to @Vitor-Avila for making the PR/SIP association here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sip Superset Improvement Proposal 🚢 2.1.3
Projects
SIPs (Superset Improvement Proposals)
Status: Implemented / Done
SIPs
PRE-DISCUSSION
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mistercrunch @rusackas @john-bodley @jileeon @ShaliniIruvuru