Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Chromatic publishing to superset-frontend storybook #21095

Conversation

eric-briscoe
Copy link
Contributor

@eric-briscoe eric-briscoe commented Aug 15, 2022

Adds new Github action to publish storybook builds to chromatic

Add Chromatic publishing to superset-fronted storybook

SUMMARY

Adds new Github action to publish storybook builds to chromatic
Fixes issue in ListViewCard stories that make the story build fail

https://www.chromatic.com/docs/github-actions

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…ybook

Adds new Github action to publish storybook builds to chromatic
Adjusts configuration to support MDX story format
Updates Alert stories to take advantage of MDX format for example in storybook that will publish to Chromatic
Fixes issue in ListViewCard stories that make the story build fail
@eric-briscoe eric-briscoe changed the title feat: Add Chromatic publishing to superset-fronted storybook feat: Add Chromatic publishing to superset-frontend storybook Aug 18, 2022
@eric-briscoe eric-briscoe marked this pull request as ready for review August 18, 2022 00:14
@eric-briscoe eric-briscoe reopened this Aug 18, 2022
@eric-briscoe eric-briscoe reopened this Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #21095 (bc466ed) into master (ca98fd8) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21095      +/-   ##
==========================================
+ Coverage   66.34%   66.39%   +0.05%     
==========================================
  Files        1773     1781       +8     
  Lines       67689    67871     +182     
  Branches     7218     7239      +21     
==========================================
+ Hits        44905    45064     +159     
- Misses      20940    20949       +9     
- Partials     1844     1858      +14     
Flag Coverage Δ
javascript 52.30% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/SqlEditor/index.jsx 50.58% <0.00%> (-1.05%) ⬇️
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 55.17% <0.00%> (-0.95%) ⬇️
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 48.48% <0.00%> (-0.73%) ⬇️
...erset-frontend/src/components/Chart/chartAction.js 55.48% <0.00%> (-0.44%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/types.ts 57.14% <0.00%> (ø)
superset-frontend/src/SqlLab/fixtures.ts 100.00% <0.00%> (ø)
...erset-frontend/src/components/EmptyState/index.tsx 76.19% <0.00%> (ø)
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <0.00%> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
... and 40 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit 6a0b7e5 into apache:master Aug 23, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants