Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Chromatic publishing to superset-frontend storybook #21095

Merged
merged 24 commits into from
Aug 23, 2022
Merged

feat: Add Chromatic publishing to superset-frontend storybook #21095

merged 24 commits into from
Aug 23, 2022

Commits on Aug 15, 2022

  1. Work in progress to add Chromatic publishing to superset-fronted stor… 

    …ybook

Adds new Github action to publish storybook builds to chromatic
Adjusts configuration to support MDX story format
Updates Alert stories to take advantage of MDX format for example in storybook that will publish to Chromatic
Fixes issue in ListViewCard stories that make the story build fail
    @eric-briscoe
    eric-briscoe committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    b428627 View commit details
    Browse the repository at this point in the history

  2. Adjust Chromatic Github action

    @eric-briscoe
    eric-briscoe committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    809a919 View commit details
    Browse the repository at this point in the history

  3. Adjust action so Gtihub Secret is read into env 

    Github secrets are not accessible in conditional blocks so this change moves the access of the github secret into an env variable which is accessible in conditional logic
    @eric-briscoe
    eric-briscoe committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    b9e5173 View commit details
    Browse the repository at this point in the history

  4. Removes unneccesary projectToken from package json

    @eric-briscoe
    eric-briscoe committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    a80e20e View commit details
    Browse the repository at this point in the history

  5. Using a temp key to debug no access to value from github secret

    @eric-briscoe
    eric-briscoe committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    0d405e5 View commit details
    Browse the repository at this point in the history

  6. Refining skipping if no changes to superset-frontend

    @eric-briscoe
    eric-briscoe committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    914d9f5 View commit details
    Browse the repository at this point in the history

  7. Remove typos from Action component story, consolidate on folder check… 

    … in Chromatic action
    @eric-briscoe
    eric-briscoe committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    7be5bc8 View commit details
    Browse the repository at this point in the history

  8. Fix error in Chromatic action event

    @eric-briscoe
    eric-briscoe committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    474d5f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Testing action with pul_request_target

    @eric-briscoe
    eric-briscoe committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    313afa4 View commit details
    Browse the repository at this point in the history

  2. adjustments to Chromatic action triggers

    @eric-briscoe
    eric-briscoe committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    36a57b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. lint fix

    @eric-briscoe
    eric-briscoe committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    a5eaeaf View commit details
    Browse the repository at this point in the history

  2. Testing if pull_request_target is disabled

    @eric-briscoe
    eric-briscoe committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    780b061 View commit details
    Browse the repository at this point in the history

  3. More adjustments to Chromatic action

    @eric-briscoe
    eric-briscoe committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    f5f2d47 View commit details
    Browse the repository at this point in the history

  4. UI Change to trigger action

    @eric-briscoe
    eric-briscoe committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    4e5cef3 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Change to story text to test action

    @eric-briscoe
    eric-briscoe committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    67233a6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ericbriscoe/sc-51041/connect-storybook-to-… 

    …chromatic-figma
    @eric-briscoe
    eric-briscoe committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    ca2b7ab View commit details
    Browse the repository at this point in the history

  3. update package-lock after merge conflicts from master

    @eric-briscoe
    eric-briscoe committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    d3408ce View commit details
    Browse the repository at this point in the history

  4. Changes to test chromatic action

    @eric-briscoe
    eric-briscoe committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    2c9eb27 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ericbriscoe/sc-51041/connect-storybook-to-… 

    …chromatic-figma
    @eric-briscoe
    eric-briscoe committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    1c82463 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Merge branch 'master' into ericbriscoe/sc-51041/connect-storybook-to-… 

    …chromatic-figma
    @eric-briscoe
    eric-briscoe committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    cd621b9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ericbriscoe/sc-51041/connect-storybook-to-… 

    …chromatic-figma
    @eric-briscoe
    eric-briscoe committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    cf02934 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Finalize Chromatic actions, fix lint errors

    @eric-briscoe
    eric-briscoe committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    d52c4a5 View commit details
    Browse the repository at this point in the history

  2. Backs out addition of @storybook/addon-docs which is included in addo… 

    …n-essentials
    @eric-briscoe
    eric-briscoe committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    96b2703 View commit details
    Browse the repository at this point in the history

  3. Lint error in package.json

    @eric-briscoe
    eric-briscoe committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    bc466ed View commit details
    Browse the repository at this point in the history