feat(nav): Update Tabbed Nav on CRUD Pages #21213

Antonio-RiveroMartnez · 2022-08-26T14:13:52Z

SUMMARY

These changes are part of a bigger collection of changes we are introducing to navigation in our menu to direct users to more useful flows.

Updates to tab menus for Databases, Datasets, Saved Queries and Query History menu
Including new tests to cover changes

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Load the app
Check all the new changes:

1. Databases page no longer shows the tabbed nav for Databases / Datasets / Saved queries / Query History
2. Datasets page no longer shows the tabbed nav for Databases / Datasets / Saved queries / Query History
3. Rename page header on Databases from "Data" to "Databases"
4. Rename page header on Datasets from "Data" to "Datasets"
5. Saved query and Query history pages both show tabbed nav with the header as "SQL" in place of what used to be "Data"
6. Databases and Datasets are removed from the SQL tabbed nav (remaining menu items are Saved queries / Query history)

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

github-actions · 2022-08-26T15:12:33Z

Storybook has completed and can be viewed at

AAfghahi

It looks like the CI has something wrong with it, you have the same error that Phillip did. . .Potentially just need a rebase.

AAfghahi · 2022-08-26T16:27:03Z

superset-frontend/src/views/CRUD/data/database/DatabaseList.test.jsx

@@ -139,6 +139,10 @@ describe('DatabaseList', () => {
    expect(wrapper.find(SubMenu)).toExist();
  });

+  it('renders a SubMenu with no tabs', () => {
+    expect(wrapper.find(SubMenu).props().tabs).toBeUndefined();


is undefined correct here or null?

undefined is correct since nothing should be passed to it, not even null.

AAfghahi · 2022-08-26T16:27:24Z

superset-frontend/src/views/CRUD/data/dataset/DatasetList.test.jsx

+  });
+
+  it('renders a SubMenu with no tabs', () => {
+    expect(wrapper.find(SubMenu).props().tabs).toBeUndefined();


same thought process here.

undefined is correct since nothing should be passed to it, not even null.

Antonio-RiveroMartnez · 2022-08-26T16:34:16Z

@AAfghahi I just rebased it, however, I can see all latest PRs failing because some new changes introduced in master regarding PivotTableChart.

github-actions · 2022-08-26T16:37:27Z

Storybook has completed and can be viewed at

lyndsiWilliams · 2022-08-26T16:49:44Z

/testenv up

github-actions · 2022-08-26T16:51:12Z

@lyndsiWilliams Container image not yet published for this PR. Please try again when build is complete.

github-actions · 2022-08-26T16:51:12Z

@lyndsiWilliams Ephemeral environment creation failed. Please check the Actions logs for details.

github-actions · 2022-08-26T17:31:19Z

Storybook has completed and can be viewed at

github-actions · 2022-08-26T18:14:15Z

Storybook has completed and can be viewed at

codecov · 2022-08-26T18:27:44Z

Codecov Report

Merging #21213 (6644a84) into master (6644a84) will not change coverage.
The diff coverage is n/a.

❗ Current head 6644a84 differs from pull request most recent head a98defe. Consider uploading reports for the commit a98defe to get more accurate results

@@           Coverage Diff           @@
##           master   #21213   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files        1793     1793           
  Lines       68532    68532           
  Branches     7282     7282           
=======================================
  Hits        45695    45695           
  Misses      20974    20974           
  Partials     1863     1863

Flag	Coverage Δ
hive	`53.08% <0.00%> (ø)`
javascript	`52.85% <0.00%> (ø)`
mysql	`78.20% <0.00%> (ø)`
postgres	`78.27% <0.00%> (ø)`
presto	`52.98% <0.00%> (ø)`
python	`81.41% <0.00%> (ø)`
sqlite	`76.76% <0.00%> (ø)`
unit	`51.06% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Antonio-RiveroMartnez · 2022-08-26T18:54:56Z

@AAfghahi all rebased and passing the checks now.

lyndsiWilliams · 2022-08-26T20:02:20Z

/testenv up

github-actions · 2022-08-26T20:04:45Z

@lyndsiWilliams Ephemeral environment spinning up at http://52.35.6.192:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

lyndsiWilliams

lgtm!

yousoph · 2022-09-20T16:43:07Z

/testenv up

github-actions · 2022-09-20T16:58:18Z

@yousoph Ephemeral environment spinning up at http://54.201.59.174:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

- Updates to tab menus for Databases, Datasets, Saved Queries and Query History menu - Including new tests to cover changes

yousoph · 2022-09-21T17:36:11Z

/testenv up

github-actions · 2022-09-21T19:26:21Z

@yousoph Ephemeral environment spinning up at http://35.89.245.103:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

eschutho

nice tests, too!

github-actions · 2022-09-21T22:50:41Z

Ephemeral environment shutdown and build artifacts deleted.

pull-request-size bot added the size/M label Aug 26, 2022

Antonio-RiveroMartnez changed the title ~~feat(nav): Updates to our menu~~ feat(nav): Update Tabbed Nav on CRUD Pages Aug 26, 2022

AAfghahi requested changes Aug 26, 2022

View reviewed changes

AAfghahi mentioned this pull request Aug 26, 2022

feat: add tableselector to dataset creation page #21075

Merged

9 tasks

Antonio-RiveroMartnez force-pushed the feature-54859 branch from d0e9c7a to 3055825 Compare August 26, 2022 16:32

Antonio-RiveroMartnez force-pushed the feature-54859 branch from 3055825 to 2c0e779 Compare August 26, 2022 17:24

Antonio-RiveroMartnez force-pushed the feature-54859 branch from 2c0e779 to e431015 Compare August 26, 2022 18:07

AAfghahi approved these changes Aug 26, 2022

View reviewed changes

lyndsiWilliams approved these changes Aug 29, 2022

View reviewed changes

Antonio-RiveroMartnez force-pushed the feature-54859 branch from e431015 to 223d29d Compare August 31, 2022 20:40

Menu:

a98defe

- Updates to tab menus for Databases, Datasets, Saved Queries and Query History menu - Including new tests to cover changes

Antonio-RiveroMartnez force-pushed the feature-54859 branch from 223d29d to a98defe Compare September 20, 2022 22:49

eschutho approved these changes Sep 21, 2022

View reviewed changes

eschutho merged commit fb835d1 into apache:master Sep 21, 2022

mistercrunch added the 🚢 2.1.3 label Feb 18, 2024

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(nav): Update Tabbed Nav on CRUD Pages #21213

feat(nav): Update Tabbed Nav on CRUD Pages #21213

Antonio-RiveroMartnez commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

AAfghahi left a comment

AAfghahi Aug 26, 2022

Antonio-RiveroMartnez Aug 26, 2022 •

edited

AAfghahi Aug 26, 2022

Antonio-RiveroMartnez Aug 26, 2022 •

edited

Antonio-RiveroMartnez commented Aug 26, 2022 •

edited

github-actions bot commented Aug 26, 2022

lyndsiWilliams commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

codecov bot commented Aug 26, 2022 •

edited

Antonio-RiveroMartnez commented Aug 26, 2022

lyndsiWilliams commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

lyndsiWilliams left a comment

yousoph commented Sep 20, 2022

github-actions bot commented Sep 20, 2022

yousoph commented Sep 21, 2022

github-actions bot commented Sep 21, 2022

eschutho left a comment

github-actions bot commented Sep 21, 2022

feat(nav): Update Tabbed Nav on CRUD Pages #21213

feat(nav): Update Tabbed Nav on CRUD Pages #21213

Conversation

Antonio-RiveroMartnez commented Aug 26, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

github-actions bot commented Aug 26, 2022

AAfghahi left a comment

Choose a reason for hiding this comment

AAfghahi Aug 26, 2022

Choose a reason for hiding this comment

Antonio-RiveroMartnez Aug 26, 2022 • edited

Choose a reason for hiding this comment

AAfghahi Aug 26, 2022

Choose a reason for hiding this comment

Antonio-RiveroMartnez Aug 26, 2022 • edited

Choose a reason for hiding this comment

Antonio-RiveroMartnez commented Aug 26, 2022 • edited

github-actions bot commented Aug 26, 2022

lyndsiWilliams commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

codecov bot commented Aug 26, 2022 • edited

Codecov Report

Antonio-RiveroMartnez commented Aug 26, 2022

lyndsiWilliams commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

lyndsiWilliams left a comment

Choose a reason for hiding this comment

yousoph commented Sep 20, 2022

github-actions bot commented Sep 20, 2022

yousoph commented Sep 21, 2022

github-actions bot commented Sep 21, 2022

eschutho left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 21, 2022

Antonio-RiveroMartnez Aug 26, 2022 •

edited

Antonio-RiveroMartnez Aug 26, 2022 •

edited

Antonio-RiveroMartnez commented Aug 26, 2022 •

edited

codecov bot commented Aug 26, 2022 •

edited