-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tableselector to dataset creation page #21075
Conversation
Storybook has completed and can be viewed at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few nits, mostly theming/TS 😁
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
Storybook has completed and can be viewed at |
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
@@ -63,14 +64,22 @@ export function datasetReducer( | |||
export default function AddDataset() { | |||
// this is commented out for now, but can be commented in as the component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can delete this comment now that we are actually using the reducer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this, remove the "this is commented out for now..." comment
This looks really nice. Put in a couple of thoughts, one question though re: spacing. The padding in the table section looks a bit wonky, is that what it was on the figma? |
…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Storybook has completed and can be viewed at |
4 similar comments
Storybook has completed and can be viewed at |
Storybook has completed and can be viewed at |
Storybook has completed and can be viewed at |
Storybook has completed and can be viewed at |
Codecov Report
@@ Coverage Diff @@
## master #21075 +/- ##
==========================================
+ Coverage 66.58% 66.60% +0.02%
==========================================
Files 1790 1790
Lines 68416 68478 +62
Branches 7287 7298 +11
==========================================
+ Hits 45554 45610 +56
- Misses 20986 20990 +4
- Partials 1876 1878 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@AAfghahi Ephemeral environment spinning up at http://52.32.56.113:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few more things, let me know if you have any questions! 😁
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
@@ -63,14 +64,22 @@ export function datasetReducer( | |||
export default function AddDataset() { | |||
// this is commented out for now, but can be commented in as the component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this, remove the "this is commented out for now..." comment
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx
Outdated
Show resolved
Hide resolved
/testenv up |
@yousoph Ephemeral environment spinning up at http://54.218.74.130:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This pr adds the database selector to the leftpanel for the new dataset creation page.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION